(10-30-2024, 06:14 PM)nchen Wrote: I appreciate you helping me with bug fixing

(11-01-2024, 12:33 AM)inkdolls Wrote: Okay, I know why the checkpoint was not being replaced: on line 26 of gp-generate-comfy-image.py, it says "CheckPointLoaderSimple" with a capital P in "Point", but the node is named "CheckpointLoaderSimple". Once I edited it, it runs fine. Understanding that part of the plugin was interesting.

I'll try to give you some more useful input about the workflow files. I realize now that modifying those is not very important for the basic stuff.

So for now I've just tested the "Generate-image" tool. Testing the others will probably take me some time. I'll get back to you if I run into other issues.

(11-03-2024, 11:58 PM)inkdolls Wrote: Looking at your files, you're using identical functions in many files. I don't know if you're aware that you can declare more than one plugin in one file calling register() repeatedly with different parameters for all the dialogs and a different function each time, so the basic code exists just once, making maintenance easier.

After more than a decade writing plugins, I learned that only quite recently.

(11-04-2024, 02:48 AM)nchen Wrote:

(11-03-2024, 11:58 PM)inkdolls Wrote: Looking at your files, you're using identical functions in many files. I don't know if you're aware that you can declare more than one plugin in one file calling register() repeatedly with different parameters for all the dialogs and a different function each time, so the basic code exists just once, making maintenance easier.

After more than a decade writing plugins, I learned that only quite recently.

Thank you, that is very good to know! So essentially I just create one python file containing all of the plugins in a bundle?
I had tried creating classes for the plugins but it became too convoluted, so I'll definitely have to give this a shot. I just manually copied and pasted all of the functions in alphabetical order, for each plugin...
Hopefully things get a bit easier with GIMP 3 as well.

• Each plugin in its own directory, together with all necessary files
  
• In such directories, Gimp only tries to register the executable that bears the same name as the directory, the other executables are ignored
  
• You of course distribute a copy of libmodule.py with each script, but given the size of python files the disk waste is minimal and you gain some upgrade independence
  

(11-04-2024, 08:09 AM)Ofnuts Wrote:

• Each plugin in its own directory, together with all necessary files
  
• In such directories, Gimp only tries to register the executable that bears the same name as the directory, the other executables are ignored
  
• You of course distribute a copy of libmodule.py with each script, but given the size of python files the disk waste is minimal and you gain some upgrade independence
  

(11-04-2024, 02:48 AM)nchen Wrote: So essentially I just create one python file containing all of the plugins in a bundle?

(11-05-2024, 02:34 AM)inkdolls Wrote: Well, you got a more expert reply that I could have given..

(11-04-2024, 08:13 PM)nchen Wrote: Thank you! That would save me a lot of time copying and pasting. I have been trying to implement this approach but I can't seem to get it to work. 
Do the functions in the 'libmodule.py' have to be registered similar to the GIMP plugins, even though GIMP doesn't check them? 
Also, are the input and output capabilities of functions within libmodule.py limited to GIMP's type codes (PF_INT, PF_FLOAT, etc)?

I have tried both registering them and not registering them to no avail.

For the example structure:
plug-ins
├── bar
│   ├── bar.py
│   └── libmodule.py

If I have a function within libmodule.py:

Code:

def insert_new_layer_with_alpha(image, width, height, name="New Layer"):
    new_layer = pdb.gimp_layer_new(image, width, height, 0, name, 100, 28)
    new_layer.add_alpha()
    pdb.gimp_image_insert_layer(image, new_layer, None, 0)
    return new_layer
register(
    "python_fu_insert-new-layer-with-alpha",     # Function Name
    "Insert new layer with alpha channel",       # Description
    "Insert a new layer with an alpha channel",  # Help
    "user",        # Author
    "user",        # Copyright
    "11/4/2024",   # Date Created
    "insert...",   # Menu label
    "",            # Image types
    [
        (PF_IMAGE, "image", "Image", None),
        (PF_INT, "int", "Width", 0),
        (PF_INT, "int", "Height", 0),
        (PF_STRING, "string", "Layer name", "New Layer")
    ],
    [
        (PF_DRAWABLE, "new_layer", "New layer")
    ],
    insert_new_layer_with_alpha, menu="<Image>/Comfy Tools")

Any time I attempt to import libmodule (with and without the register within libmodule.py), bar.py fails to register.
I have also tried registering and then calling insert_new_layer_with_alpha directly without importing.

I did test if the function within libmodule.py registers successfully to be sure it's not an error within the function.

The only time I've been able to get bar.py to register is when I don't attempt to import or call the functions within libmodule.py.

EDIT:
A kind of funny workaround I've been using sometimes is just installing a newer python version on my machine and calling it from the plugins:

Code:

import subprocess
   input_data = data
    # Run the script and pass the input data
    process = subprocess.Popen(
        ["py", "path/to/script/python3script.py"],
        stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
    )
    stdout, stderr = process.communicate(input=input_data.encode('utf-8'))
    result = stdout if process.returncode == 0 else stderr