10-26-2022, 05:30 PM
(10-26-2022, 09:58 AM)programmer_ceds Wrote:(10-26-2022, 03:25 AM)teapot Wrote: Why are they changing this? The arrow script issue wasn't a gimp bug. Do you have a link to the issue that was raised requesting it?
The arrow script bug that we were discussing previously was in V2.10.32 - the issue that I have raised relates to the behaviour of standard GIMP functions (Edit/Stroke Path and Edit/Stroke Selection) in GIMP V2.99.12/13 - it just happens that I noticed it when testing the V3 version of the arrow script and found that the arrow shafts were being drawn in the wrong place. This is not as a result of any change made to GIMP as a result of the recent arrow script changes - I didn't raise an issue for that (thankfully users of this site pointed out the error of my ways before I embarrassed myself on the GIMP site!) The code that is causing the problem lies in functions gimp_paint_core_stroke_vector() and gimp_paint_core_stroke_selection() (stroking selections has the same problem) in file app/paint/gimppaintcore-stroke.c this code remains unchanged from V2.10.32 - it is not something that has been introduced recently.
(10-26-2022, 03:25 AM)teapot Wrote: Hardly surprising, change the coordinates and there will be consequences, possibly more than you have found so far. Not to mention the many plugins that were handling the layer offset correctly will become broken.
That is quite possible but when the standard Edit/Stroke Path and Edit/Stroke Selection don't function correctly with offset layers there is a problem that needs to be fixed. It could be that I am doing something wrong but I can't see a problem with the procedure that I noted in the GIMP issue - if there is a problem with my procedure then I can see numerous others falling into the same trap.
If there is something that determines whether or not strokes appear in the correct place on offset layers then we need to know what that something is and how to recognise it. The latest comment from the developer suggests that there is a possibility that they may have been mistaken in thinking that the stroke sometimes appeared in the correct place (see the latest posts on the GIMP issue). However, if anyone else can get paths and/or selections stroked in the correct places in V2.99.12/13 I should like to hear from them (preferably with an xcf file that shows this working correctly).
(10-26-2022, 03:25 AM)teapot Wrote: I don't fancy using different coordinates depending on how I stroke the path.
Quite - the corrections that I have identified relate to the functions that stroke selections and paths (vectors) using the paintbrush tool - implementing these corrections will mean that stroking with a line or with a paint tool will result in the strokes appearing in the same places regardless of the method used to create the strokes.
Thanks for your reply.
From a quick look, it might be commit 8934d43975 is causing the issue. https://gitlab.gnome.org/GNOME/gimp/-/commit/8934d43975
It's part of GIMP_2_99_6-398-g8934d43975 and you were using V2.99.12/13.
Jehan says:
At this step, it is still very bugged and not really working properly. In particular, since we don't process the drawable offset early anymore (because it makes no sense when we pass a list of drawables with different offsets), I suspect that all the offset-related code will be very broken.