01-06-2025, 09:03 AM
elif(background_type == 1 or background_type == 2 or background_type == 3) better written as if background_type in [1,2,3]
elif(background_type == 4): # transparent background
# do nothing since resized canvas background is already transparent
pass
better written as
else: # transparent background case: do nothing since resized canvas background is already transparent
pass
(always better to have an explicit else to catch what we could have forgotten)
Instead of saving the color, you can bracket your code with gimp.context_push()/gimp.context_pop() (like the undo group), so that any context change you make for the script is reset when the script exits.
Blur radius can be a PF_SLIDER, easier for the user and since you add value boundaries you naturally limit the user to what Gimp's blur allows.
When you use pre-defined values as parameters, use their name, for instance pdb.gimp_image_merge_down(image, drawable, 1) is better written pdb.gimp_image_merge_down(image, drawable,CLIP_TO_IMAGE ) (note the "-/_" substitution).
elif(background_type == 4): # transparent background
# do nothing since resized canvas background is already transparent
pass
better written as
else: # transparent background case: do nothing since resized canvas background is already transparent
pass
(always better to have an explicit else to catch what we could have forgotten)
Instead of saving the color, you can bracket your code with gimp.context_push()/gimp.context_pop() (like the undo group), so that any context change you make for the script is reset when the script exits.
Blur radius can be a PF_SLIDER, easier for the user and since you add value boundaries you naturally limit the user to what Gimp's blur allows.
When you use pre-defined values as parameters, use their name, for instance pdb.gimp_image_merge_down(image, drawable, 1) is better written pdb.gimp_image_merge_down(image, drawable,CLIP_TO_IMAGE ) (note the "-/_" substitution).